• DevPilot's avatar
    fix(accounting): GapController fataled on load — private override of a protected parent method · f4ef51e9
    DevPilot authored
    `GapController::currentEmployee()` was declared private where
    App\Core\Controller declares it protected. PHP rejects that at class-load
    time, not at call time, so every request to /accounting/gaps returned a
    500 — the screen was unreachable since it shipped in caca1389.
    
    The override was redundant anyway: the parent's currentEmployee() does
    exactly the same thing. Removed it, and the now-unused App import with it.
    
    Missed because the earlier verification exercised the services and
    rendered the views directly, but never instantiated the controller —
    which is precisely where this class of error surfaces. Added that check
    (reflect + instantiate every new controller, resolve every route handler
    class and method) and ran it across all 1,486 routes in the system.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    f4ef51e9
Name
Last commit
Last update
..
Controllers Loading commit data...
Models Loading commit data...
Services Loading commit data...
Views Loading commit data...
AccountCodes.php Loading commit data...
JournalServiceAdapter.php Loading commit data...
Routes.php Loading commit data...
bootstrap.php Loading commit data...