• DevPilot's avatar
    fix(accounting): GapController fataled on load — private override of a protected parent method · f4ef51e9
    DevPilot authored
    `GapController::currentEmployee()` was declared private where
    App\Core\Controller declares it protected. PHP rejects that at class-load
    time, not at call time, so every request to /accounting/gaps returned a
    500 — the screen was unreachable since it shipped in caca1389.
    
    The override was redundant anyway: the parent's currentEmployee() does
    exactly the same thing. Removed it, and the now-unused App import with it.
    
    Missed because the earlier verification exercised the services and
    rendered the views directly, but never instantiated the controller —
    which is precisely where this class of error surfaces. Added that check
    (reflect + instantiate every new controller, resolve every route handler
    class and method) and ran it across all 1,486 routes in the system.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    f4ef51e9
Name
Last commit
Last update
.claude Loading commit data...
Another ERP that we may want to cheat from Loading commit data...
HR requests Loading commit data...
Proposal Loading commit data...
Server Connection Data Loading commit data...
app Loading commit data...
config Loading commit data...
cron Loading commit data...
database Loading commit data...
docker Loading commit data...
docs Loading commit data...
public Loading commit data...
support_tickets_downloads/support_screenshots Loading commit data...
tests Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.env Loading commit data...
.env.example Loading commit data...
.gitignore Loading commit data...
.php-cs-fixer.php Loading commit data...
BalanceSheet.html Loading commit data...
CLAUDE.md Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
SYSTEM_MAP.md Loading commit data...
Sports Module System Design DETAILED.md Loading commit data...
UPGRADE_PLAN.md Loading commit data...
captain-definition Loading commit data...
cli.php Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
interesting_features.md Loading commit data...
phpstan.neon Loading commit data...
phpunit.xml Loading commit data...
sports activity stuff .txt Loading commit data...
sports-activity-alignment-plan.md Loading commit data...
sports-activity-smart-filtering-plan.md Loading commit data...
trial_balance_2026-01-01_to_2026-05-10.csv Loading commit data...