• Mahmoud Aglan's avatar
    fix(financial): stop binding NULL as a filter Postgres cannot type · 75fbca7a
    Mahmoud Aglan authored
    The financial overview 500'd with SQLSTATE 42P08 on `($4 IS NULL OR
    p.branch_id = $4)`. Postgres fixes each prepared-statement parameter's type
    during parse analysis, and `:branch_id IS NULL` gives it nothing to work from
    — the statement is rejected before it ever reaches the comparison that would
    have typed it. `:academy_id` was the same shape and would have failed next.
    
    The idiom came in with 35200985 and could not be caught here: phpunit runs
    SQLite in memory, which types placeholders at bind time and executes the
    broken form happily.
    
    Fixed by appending the branch and academy filters only when they apply, with
    their bindings, rather than passing NULL as a sentinel — which is what the
    ->when() filters in the same method already do, and keeps the
    (academy_id, branch_id) index usable instead of hiding it behind an OR.
    
    The SQL build is extracted to buildTopProgramsQuery() so it can be asserted on
    without a database. The test pins four things: the placeholders and the
    bindings agree in all four filter combinations, the clauses are omitted rather
    than nulled, the built SQL executes, and no raw SQL under app/ binds a
    placeholder as a NULL sentinel again. That last one is a source scan on
    purpose — the suite's driver is not the production driver, so it cannot
    observe this failure by running.
    Co-Authored-By: 's avatarClaude Opus 5 (1M context) <noreply@anthropic.com>
    75fbca7a