• Mahmoud Aglan's avatar
    fix(sports-activity): resolve broken queries, fee/threshold drift, and billing gaps · e139a8a2
    Mahmoud Aglan authored
    - ActivitySubscriptions: fix generate/calculateRate querying nonexistent
      `enrollments` table; use `academy_enrollments` with correct columns
    - SportsDashboard: fix queries against nonexistent `disciplines` table;
      use `sport_disciplines`
    - Sports: unify conversion-fee percentage to a single source
      (MembershipRulesService::getAthleticMemberConversionRules), preventing
      the eligibility preview from drifting from what's actually charged
    - SportsActivity: align absence-threshold fallback defaults between
      AttendanceRuleService and TrainingAttendanceService via a shared constant
    - SportsActivity: auto-bill first month on Registration Wizard completion,
      matching the direct-enrollment path so wizard-registered players aren't
      left uncharged until the monthly batch runs
    - ActivitySubscriptions: guard paySubscription() to only transition
      pending/overdue -> paid, making it idempotent against the (currently
      unreachable) payment.completed listener path
    - ActivitySubscriptions: dispatch academy.enrollment_created from the
      enroll wizard so PlayerAffairs' auto-billing listener actually fires
    
    Also adds/updates Architecture Maps for Sports, SportsActivity,
    SportsDashboard, ActivitySubscriptions and the cross-module Dependency
    Graph, per this repo's mandatory architecture-map workflow.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    Co-Authored-By: 's avatarClaude Sonnet 5 <noreply@anthropic.com>
    e139a8a2
Name
Last commit
Last update
.claude Loading commit data...
Another ERP that we may want to cheat from Loading commit data...
HR requests Loading commit data...
Proposal Loading commit data...
Server Connection Data Loading commit data...
app Loading commit data...
config Loading commit data...
cron Loading commit data...
database Loading commit data...
docker Loading commit data...
docs Loading commit data...
public Loading commit data...
support_tickets_downloads/support_screenshots Loading commit data...
tests Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.env Loading commit data...
.env.example Loading commit data...
.gitignore Loading commit data...
.php-cs-fixer.php Loading commit data...
BalanceSheet.html Loading commit data...
CLAUDE.md Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
SYSTEM_MAP.md Loading commit data...
Sports Module System Design DETAILED.md Loading commit data...
UPGRADE_PLAN.md Loading commit data...
captain-definition Loading commit data...
cli.php Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
interesting_features.md Loading commit data...
phpstan.neon Loading commit data...
phpunit.xml Loading commit data...
sports activity stuff .txt Loading commit data...
sports-activity-alignment-plan.md Loading commit data...
sports-activity-smart-filtering-plan.md Loading commit data...
trial_balance_2026-01-01_to_2026-05-10.csv Loading commit data...