• Mahmoud Aglan's avatar
    fix(registration): prevent double form-fee charge + NID-swap exploit + profile actions · db92e175
    Mahmoud Aglan authored
    Critical fixes:
    - submitFormPayment() now checks sa_players.registration_fee_paid as
      a safety net before creating any payment request
    - startRegistration() member_id fallback only used when NID matches
      the member's actual national_id (prevents NID-swap fee bypass)
    - lookupPlayer() validates NID-to-member consistency before proceeding
    - Existing registration lookup now includes 'pending_payment' status
    - Frontend clears membership_number when NID is manually changed
      after auto-fill
    
    Feature:
    - Player profile page now shows "Print Form" and "Generate Card"
      buttons for completing registration steps outside the wizard
    Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
    db92e175
Name
Last commit
Last update
.claude Loading commit data...
Another ERP that we may want to cheat from Loading commit data...
Server Connection Data Loading commit data...
app Loading commit data...
config Loading commit data...
cron Loading commit data...
database Loading commit data...
docker Loading commit data...
docs Loading commit data...
public Loading commit data...
support_tickets_downloads/support_screenshots Loading commit data...
tests Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.env Loading commit data...
.env.example Loading commit data...
.gitignore Loading commit data...
.php-cs-fixer.php Loading commit data...
BalanceSheet.html Loading commit data...
CLAUDE.md Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
SYSTEM_MAP.md Loading commit data...
UPGRADE_PLAN.md Loading commit data...
captain-definition Loading commit data...
cli.php Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
interesting_features.md Loading commit data...
phpstan.neon Loading commit data...
phpunit.xml Loading commit data...
sports activity stuff .txt Loading commit data...
sports-activity-alignment-plan.md Loading commit data...
sports-activity-smart-filtering-plan.md Loading commit data...
trial_balance_2026-01-01_to_2026-05-10.csv Loading commit data...