• Mahmoud Aglan's avatar
    feat(accounting): one split, applied across any scope of revenue · c95a8dd4
    Mahmoud Aglan authored
    The wizard could only ever rewire one stream at a time, so making a policy
    ("this is how we split membership money") meant repeating the same work per
    stream — 97 streams across 14 categories. The split is now written once and
    pushed onto whatever it should govern.
    
    Scopes: this stream, a whole category, a hand-picked set, everything not yet
    mapped, or all of it. The screen shows the resolved target list and the count
    before anything is written, and each target still gets its own versioned rule
    — nothing is shared and nothing is retroactive.
    
    AllocationPlanService is the guard rail. Every save runs resolveTargets ->
    validate -> apply, apply() re-validates on its own (there is no FK on
    account_id, so an unvalidated write would point rules at accounts that do not
    exist), and the whole batch is one transaction — a single bad target rolls
    back all of it rather than leaving the chart half-rewired.
    
    Refused before a row is written, all verified against a clone of production:
    header accounts, missing/archived accounts, no remainder line, two remainder
    lines, percentages over 100, zero and negative values, a line type that does
    not match its account's type, an expense line on a collection, mixing inflow
    and outflow streams in one scope, an effective date inside a closed period,
    a deferred line with no recognition account, and a stage the category cannot
    produce (skipped with a reason rather than written).
    
    Also:
    - Direction now drives which line types exist at all, and is editable per
      stream from the wizard. Phase_106_001 corrects 11 payroll/procurement
      streams seeded as 'inflow' — a salary expense and a supplier payment are
      debits, and the screen was offering revenue accounts for them.
    - parseLines() accepted 5 of the 12 line types the schema allows, which made
      outflow streams impossible to configure at all. It now accepts all of them.
    - Deferred revenue is configurable from the wizard (months + recognition
      account, filtered to revenue accounts).
    - The entry preview inverts for outflow: split lines debit, cash credits.
    
    Arithmetic verified against RevenueAllocator at 0.03, 1.00, 150,000.00 and
    999,999.99 EGP, and with 14% inclusive VAT — balanced in every case.
    Co-Authored-By: 's avatarClaude Opus 5 (1M context) <noreply@anthropic.com>
    c95a8dd4
Name
Last commit
Last update
.claude Loading commit data...
Another ERP that we may want to cheat from Loading commit data...
HR requests Loading commit data...
Proposal Loading commit data...
Server Connection Data Loading commit data...
app Loading commit data...
config Loading commit data...
cron Loading commit data...
database Loading commit data...
docker Loading commit data...
docs Loading commit data...
public Loading commit data...
support_tickets_downloads/support_screenshots Loading commit data...
tests Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.env Loading commit data...
.env.example Loading commit data...
.gitignore Loading commit data...
.php-cs-fixer.php Loading commit data...
BalanceSheet.html Loading commit data...
CLAUDE.md Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
SYSTEM_MAP.md Loading commit data...
Sports Module System Design DETAILED.md Loading commit data...
UPGRADE_PLAN.md Loading commit data...
captain-definition Loading commit data...
cli.php Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
interesting_features.md Loading commit data...
phpstan.neon Loading commit data...
phpunit.xml Loading commit data...
sports activity stuff .txt Loading commit data...
sports-activity-alignment-plan.md Loading commit data...
sports-activity-smart-filtering-plan.md Loading commit data...
trial_balance_2026-01-01_to_2026-05-10.csv Loading commit data...