• DevPilot's avatar
    fix(accounting): make the advances reclassification actually runnable, and safe afterwards · 9f48d4aa
    DevPilot authored
    Phase_107_002 has never run. Its first INSERT wrote to chart_of_accounts.notes,
    a column that does not exist, so the migration threw and MigrationRunner swallowed
    it — leaving 3,032,258 EGP of member advances sitting in revenue this whole time.
    Writing to description_ar instead lets it complete.
    
    That exposed a second problem the original migration would have caused. It
    deactivates 410503/504/505, but payment:down_payment carries an active posting
    rule crediting 410503. Deactivating the account without moving the rule means
    every future down payment records a receipt and posts no journal entry, because
    JournalService refuses an inactive account — quietly worse than the overstatement
    being fixed. The rule now moves to the matching contract-liability account, which
    is where a down payment belonged anyway: it is an advance from the moment it is
    collected, and only becomes revenue as the service is delivered. Otherwise the
    account being emptied would just refill.
    
    Also seeds the four bank accounts the chart already names as the club's current
    accounts. bank_accounts was empty, which is why the cash chain's deposit step
    had nothing to resolve and reported red. Account numbers are deliberate
    placeholders reading "رقم الحساب غير محدد" — a seed has no business inventing an
    IBAN that could reach a printed deposit slip — and the seed never overwrites a
    row someone has already filled in.
    
    And drops POST /waivers/{id}/pay: WaiverController::pay() does not exist, so the
    route was a guaranteed 500. Leftover from a direct-payment design that
    send-to-cashier replaced; nothing posts to it.
    
    Verified on a full 369-table production clone: balances move (410503/504/505 -> 0,
    deactivated; 23081119/20/21 created), entry balances Dr=Cr=3,032,258.00, re-runs
    post nothing, down payments still post clean, no active rule anywhere resolves to
    a dead or header account, all four chains green, trial balance diff 0.00.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    9f48d4aa
Name
Last commit
Last update
..
Academies Loading commit data...
AcademyContracts Loading commit data...
AccessMatrix Loading commit data...
Accounting Loading commit data...
Achievements Loading commit data...
ActivitySubscriptions Loading commit data...
Alerts Loading commit data...
Archive Loading commit data...
Audit Loading commit data...
Auth Loading commit data...
Branches Loading commit data...
Carnets Loading commit data...
Cashier Loading commit data...
Children Loading commit data...
Coaches Loading commit data...
Dashboard Loading commit data...
Death Loading commit data...
Disciplines Loading commit data...
Divorce Loading commit data...
Documents Loading commit data...
Facilities Loading commit data...
FacilityDashboards Loading commit data...
FacilityGrids Loading commit data...
Fines Loading commit data...
Foreign Loading commit data...
Forms Loading commit data...
HR Loading commit data...
Honorary Loading commit data...
Installments Loading commit data...
Interviews Loading commit data...
Inventory Loading commit data...
MatchCenter Loading commit data...
MedicalBoard Loading commit data...
Members Loading commit data...
News Loading commit data...
Notifications Loading commit data...
ParentPortal Loading commit data...
Payments Loading commit data...
PlayerAffairs Loading commit data...
PlayerApi Loading commit data...
PlayerAuth Loading commit data...
PlaygroundAdmin Loading commit data...
PoolManagement Loading commit data...
Pricing Loading commit data...
Procurement Loading commit data...
Receipts Loading commit data...
Rentals Loading commit data...
Reports Loading commit data...
Reservations Loading commit data...
Roles Loading commit data...
Rules Loading commit data...
Sales Loading commit data...
Scheduling Loading commit data...
Seasonal Loading commit data...
ServiceCatalog Loading commit data...
Sessions Loading commit data...
Settings Loading commit data...
Sports Loading commit data...
SportsActivity Loading commit data...
SportsDashboard Loading commit data...
Spouses Loading commit data...
Subscriptions Loading commit data...
Support Loading commit data...
Temporary Loading commit data...
Tournaments Loading commit data...
TrainerPortal Loading commit data...
Training Loading commit data...
TrainingGroups Loading commit data...
Transfers Loading commit data...
Treasury Loading commit data...
Tutorials Loading commit data...
Users Loading commit data...
Waiver Loading commit data...
Workflow Loading commit data...