• Mahmoud Aglan's avatar
    fix(facilities): five screens queried a reservations column that does not exist · 8af96aea
    Mahmoud Aglan authored
    `reservations` identifies its booker with booker_type plus player_id / member_id.
    There is no booker_id column — confirmed with SHOW COLUMNS on the live database,
    not from the migrations. Five call sites queried it anyway, so every one of them
    threw a SQL error:
    
      FacilityDashboards/Controllers/FacilityDashboardController.php  (x2)
      PlaygroundAdmin/Services/ClubDashboardService.php               (x2)
      PlaygroundAdmin/Services/PlaygroundMirrorService.php            (x3)
      FacilityGrids/Services/PoolFinancialService.php                 (x1)
      PlayerApi/Services/PlayerBookingService.php                     (x4)
    
    Effect: the facility dashboard, the club-wide playground dashboard, the pool
    financial panel and the playground mirror hard-500 on every load, and the player
    app could never create a booking — the INSERT named booker_id too. That matches
    the data: 7 reservations exist with booker_type set and player_id/member_id both
    NULL, and zero player bookings.
    
    Reads become COALESCE(player_id, member_id); the joins key on the specific column
    for their booker_type; the INSERT writes player_id.
    
    Also PlaygroundMirrorService queried private_match_bookings.match_date, which is
    booking_date on that table. (live_matches genuinely has match_date, so MatchCenter
    is untouched.) And sa_bookings / pool_bookings really do have booker_id, so those
    references are correct and left alone.
    
    Every rewritten query was executed against the live database before committing.
    Co-Authored-By: 's avatarClaude Opus 5 (1M context) <noreply@anthropic.com>
    8af96aea
Name
Last commit
Last update
.claude Loading commit data...
Another ERP that we may want to cheat from Loading commit data...
HR requests Loading commit data...
Proposal Loading commit data...
Server Connection Data Loading commit data...
app Loading commit data...
config Loading commit data...
cron Loading commit data...
database Loading commit data...
docker Loading commit data...
docs Loading commit data...
public Loading commit data...
support_tickets_downloads/support_screenshots Loading commit data...
tests Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.env Loading commit data...
.env.example Loading commit data...
.gitignore Loading commit data...
.php-cs-fixer.php Loading commit data...
BalanceSheet.html Loading commit data...
CLAUDE.md Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
SYSTEM_MAP.md Loading commit data...
Sports Module System Design DETAILED.md Loading commit data...
UPGRADE_PLAN.md Loading commit data...
captain-definition Loading commit data...
cli.php Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
interesting_features.md Loading commit data...
phpstan.neon Loading commit data...
phpunit.xml Loading commit data...
sports activity stuff .txt Loading commit data...
sports-activity-alignment-plan.md Loading commit data...
sports-activity-smart-filtering-plan.md Loading commit data...
trial_balance_2026-01-01_to_2026-05-10.csv Loading commit data...