• DevPilot's avatar
    fix(rentals): contract page fataled for every approved contract · 808c63d1
    DevPilot authored
    I broke this. The page-actions block reads $gracePeriod to build the
    bulk-generate confirmation, but $gracePeriod was computed inside the content
    block — and page_actions renders first, so the variable did not exist yet.
    Production turns that notice into a fatal, so the contract page died outright.
    
    It had always been wrong; it was simply unreachable, because the guard above it
    requires status approved or active and until yesterday no contract could reach
    those states (the approve button was hidden on drafts). Making approval possible
    made the broken path reachable, and I shipped it without exercising the page in
    the state I had just unlocked.
    
    The shared variables now sit above both sections, which is where anything either
    section needs has to be.
    
    Why the test missed it: I was piping render output through `grep -v Warning:`,
    which filtered out the exact notice that is fatal in production. The check now
    installs an error handler that promotes every notice to an exception — the same
    thing ExceptionHandler does — and renders the contract page in all eight
    statuses and the invoice page in all three. All pass.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    808c63d1
Name
Last commit
Last update
..
Academies Loading commit data...
AcademyContracts Loading commit data...
AccessMatrix Loading commit data...
Accounting Loading commit data...
Achievements Loading commit data...
ActivitySubscriptions Loading commit data...
Alerts Loading commit data...
Archive Loading commit data...
Audit Loading commit data...
Auth Loading commit data...
Branches Loading commit data...
Carnets Loading commit data...
Cashier Loading commit data...
Children Loading commit data...
Coaches Loading commit data...
Dashboard Loading commit data...
Death Loading commit data...
Disciplines Loading commit data...
Divorce Loading commit data...
Documents Loading commit data...
Facilities Loading commit data...
FacilityDashboards Loading commit data...
FacilityGrids Loading commit data...
Fines Loading commit data...
Foreign Loading commit data...
Forms Loading commit data...
HR Loading commit data...
Honorary Loading commit data...
Installments Loading commit data...
Interviews Loading commit data...
Inventory Loading commit data...
MatchCenter Loading commit data...
MedicalBoard Loading commit data...
Members Loading commit data...
News Loading commit data...
Notifications Loading commit data...
ParentPortal Loading commit data...
Payments Loading commit data...
PlayerAffairs Loading commit data...
PlayerApi Loading commit data...
PlayerAuth Loading commit data...
PlaygroundAdmin Loading commit data...
PoolManagement Loading commit data...
Pricing Loading commit data...
Procurement Loading commit data...
Receipts Loading commit data...
Rentals Loading commit data...
Reports Loading commit data...
Reservations Loading commit data...
Roles Loading commit data...
Rules Loading commit data...
Sales Loading commit data...
Scheduling Loading commit data...
Seasonal Loading commit data...
ServiceCatalog Loading commit data...
Sessions Loading commit data...
Settings Loading commit data...
Sports Loading commit data...
SportsActivity Loading commit data...
SportsDashboard Loading commit data...
Spouses Loading commit data...
Subscriptions Loading commit data...
Support Loading commit data...
Temporary Loading commit data...
Tournaments Loading commit data...
TrainerPortal Loading commit data...
Training Loading commit data...
TrainingGroups Loading commit data...
Transfers Loading commit data...
Treasury Loading commit data...
Tutorials Loading commit data...
Users Loading commit data...
Waiver Loading commit data...
Workflow Loading commit data...