• DevPilot's avatar
    feat(rentals): collect a rental invoice into a treasury from the invoice screen · 758eaebf
    DevPilot authored
    The rent could be invoiced but not collected. `payInvoice` required a
    `payment_id` that already existed, and the form asked the accountant to type
    "رقم الدفعة من النظام" — a number they had no way to obtain, because nothing on
    this screen created a payment. So a generated invoice could never be settled.
    
    `collectInvoice` takes the money properly: pick the treasury, the method and the
    date, and it writes the payment against that treasury, then settles the invoice
    through the same RentalInvoiceService::markPaid the old path used — so the late
    fee is still calculated from the due date and the journal entry is unchanged.
    
    payInvoice is left in place for the case it was built for: a cashier who already
    raised the receipt and has its number.
    
    Verified end to end on a production clone: contract approved, 12 monthly
    invoices generated on the contract's own payment_due_day, one collected into
    «الخزنة الرئيسية», and the entry posted Dr الصندوق / Cr إيجار محلات + ض.ق.م with
    the trial balance still at 0.00.
    Co-Authored-By: 's avatarClaude Opus 5 <noreply@anthropic.com>
    758eaebf
Name
Last commit
Last update
.claude Loading commit data...
Another ERP that we may want to cheat from Loading commit data...
HR requests Loading commit data...
Proposal Loading commit data...
Server Connection Data Loading commit data...
app Loading commit data...
config Loading commit data...
cron Loading commit data...
database Loading commit data...
docker Loading commit data...
docs Loading commit data...
public Loading commit data...
support_tickets_downloads/support_screenshots Loading commit data...
tests Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.env Loading commit data...
.env.example Loading commit data...
.gitignore Loading commit data...
.php-cs-fixer.php Loading commit data...
BalanceSheet.html Loading commit data...
CLAUDE.md Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
SYSTEM_MAP.md Loading commit data...
Sports Module System Design DETAILED.md Loading commit data...
UPGRADE_PLAN.md Loading commit data...
captain-definition Loading commit data...
cli.php Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
interesting_features.md Loading commit data...
phpstan.neon Loading commit data...
phpunit.xml Loading commit data...
sports activity stuff .txt Loading commit data...
sports-activity-alignment-plan.md Loading commit data...
sports-activity-smart-filtering-plan.md Loading commit data...
trial_balance_2026-01-01_to_2026-05-10.csv Loading commit data...