• Fares's avatar
    fix(subscriptions): prevent duplicate subscription rows with unique constraint · 5a5aba46
    Fares authored
    Root causes of duplicate members in yearly subscriptions:
    1. No DB-level unique constraint allowed race conditions between
       SubscriptionGenerator, SyncService, and RetroactiveMembershipService
    2. SyncService set person_id=NULL for member rows vs Generator's person_id=memberId
    3. RetroactiveMembershipService did blind INSERTs with no dedup check
    
    Fix:
    - Migration removes existing duplicates (keeps paid row, lowest ID tiebreak)
    - Normalizes NULL person_id on member rows
    - Adds UNIQUE INDEX (member_id, financial_year, person_type, person_id)
    - All insert paths catch Duplicate entry exceptions as race guard
    - SyncService now sets person_id=memberId matching Generator
    - RetroactiveMembershipService checks for existing row before INSERT
    Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
    5a5aba46
Name
Last commit
Last update
.claude Loading commit data...
Another ERP that we may want to cheat from Loading commit data...
Server Connection Data Loading commit data...
app Loading commit data...
config Loading commit data...
cron Loading commit data...
database Loading commit data...
docker Loading commit data...
docs Loading commit data...
public Loading commit data...
support_tickets_downloads/support_screenshots Loading commit data...
tests Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.env Loading commit data...
.env.example Loading commit data...
.gitignore Loading commit data...
.php-cs-fixer.php Loading commit data...
BalanceSheet.html Loading commit data...
CLAUDE.md Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
SYSTEM_MAP.md Loading commit data...
UPGRADE_PLAN.md Loading commit data...
captain-definition Loading commit data...
cli.php Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
interesting_features.md Loading commit data...
phpstan.neon Loading commit data...
phpunit.xml Loading commit data...
sports activity stuff .txt Loading commit data...
sports-activity-alignment-plan.md Loading commit data...
sports-activity-smart-filtering-plan.md Loading commit data...
trial_balance_2026-01-01_to_2026-05-10.csv Loading commit data...