• Mahmoud Aglan's avatar
    Comprehensive subscription cycle fix: data integrity, fines, retroactive entries · 2da473e7
    Mahmoud Aglan authored
    Migration Phase_92_005:
    - Fix missing dev fee on member rows
    - Apply 50% discount to 2023/2024 rows that missed it
    - Recalculate total_amount where it doesn't match (base - discount)
    - Fix paid rows with 0 paid_amount (set paid_amount = total)
    - Reset all fine_amounts to 0 (recalculated on page visit)
    
    Code fixes:
    - OverdueFineApplicator: only write fine_amount if actually changed
    - SubscriptionCalculator: expose subscription_total in fine details
    - SubscriptionController: pick single dev fee per year (not SUM)
    - View: show correct base (subscription_total) in fine detail panel
    - RetroactiveMembershipService: don't accept form paid_amount for
      status=paid (server calculates correct value); remove dev fee
      from paid_amount (dev fee is invoice-level, not per-row)
    - RetroactiveWizardController: remove misleading 492/527 defaults
    - OverdueFineJob: run year-round (grace period handled by calculator)
    Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
    2da473e7
Name
Last commit
Last update
.claude Loading commit data...
Another ERP that we may want to cheat from Loading commit data...
Server Connection Data Loading commit data...
app Loading commit data...
config Loading commit data...
cron Loading commit data...
database Loading commit data...
docker Loading commit data...
docs Loading commit data...
public Loading commit data...
support_tickets_downloads/support_screenshots Loading commit data...
tests Loading commit data...
tools Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.env Loading commit data...
.env.example Loading commit data...
.gitignore Loading commit data...
.php-cs-fixer.php Loading commit data...
BalanceSheet.html Loading commit data...
CLAUDE.md Loading commit data...
Dockerfile Loading commit data...
Makefile Loading commit data...
SYSTEM_MAP.md Loading commit data...
UPGRADE_PLAN.md Loading commit data...
captain-definition Loading commit data...
cli.php Loading commit data...
composer.json Loading commit data...
composer.lock Loading commit data...
interesting_features.md Loading commit data...
phpstan.neon Loading commit data...
phpunit.xml Loading commit data...
sports activity stuff .txt Loading commit data...
sports-activity-alignment-plan.md Loading commit data...
sports-activity-smart-filtering-plan.md Loading commit data...
trial_balance_2026-01-01_to_2026-05-10.csv Loading commit data...