Skip to content

C
Clubphp
Switch branch/tag
  1. 18 Jul, 2026 4 commits
    • Mahmoud Aglan's avatar
      feat(installments): business-intelligence show page + recalculate action · 6beb4544
      Mahmoud Aglan authored 
      - Complete rewrite of show.php: 6 KPI cards (original amount, down payment,
  remaining balance, interest, monthly payment, member's outstanding balance),
  progress bar showing paid vs total installments, financial breakdown panels
  (paid vs remaining split), grand total formula ribbon, overdue alerts,
  next-due-date card with countdown, enhanced schedule table with status
  highlighting and per-row pay forms
- Add recalculate() action to InstallmentController: corrects pending-only
  installment rows to flat simple-interest formula without touching paid rows
- Register POST /installments/{id}/recalculate route
Co-Authored-By: 's avatarClaude Sonnet 4.6 <noreply@anthropic.com>
      6beb4544
    • Mahmoud Aglan's avatar
      feat(subscriptions): auto-sync FY subscription row when dependent is activated · 58084696
      Mahmoud Aglan authored 
      SubscriptionSyncService::syncForDependent() inserts a pending subscription
row for the current financial year whenever a spouse, child, or temporary
member becomes active. Triggered via two paths in Subscriptions bootstrap:

- Cashier path: spouse.fee_paid / child.fee_paid / temporary.fee_paid
- Zero-fee path: *.added events where fee = 0 (immediate activation)

Guards: member must be active + non-exempt type; dedup prevents duplicates.
Rates resolved identically to SubscriptionGenerator (year-specific catalog
code → generic code → hard fallback). Never throws — safe in event context.
Co-Authored-By: 's avatarClaude Sonnet 4.6 <noreply@anthropic.com>
      58084696
    • Mahmoud Aglan's avatar
      fix(installments): correct interest formula to flat simple interest prorated by duration · 8b7ccbd6
      Mahmoud Aglan authored 
      All calculation sites now use: interest = remaining × (rate/100) × (months/12)
instead of diminishing-balance amortization.

Changes across all 6 sites:
- InstallmentCalculator: flat interest, equal monthly instalments
- PricingEngine: same formula
- RetroactiveMembershipService: same formula
- retroactive-wizard JS: updated preview + shows المبلغ المتبقي in summary
- Members/show.php: preview panel now includes months factor (was missing)
- Installments/create.php: added live المبلغ المتبقي preview panel
Co-Authored-By: 's avatarClaude Sonnet 4.6 <noreply@anthropic.com>
      8b7ccbd6
    • Mahmoud Aglan's avatar
      fix(members): add novalidate to retroactive wizard form to suppress browser validation errors · 0d8aafd7
      Mahmoud Aglan authored 
      Native HTML5 constraint validation fires on hidden fields (display:none panels),
causing "not focusable" errors on inst_months. Custom validateStep() handles all
validation — novalidate disables the duplicate browser check.
Co-Authored-By: 's avatarClaude Sonnet 4.6 <noreply@anthropic.com>
      0d8aafd7
  3. 09 Jul, 2026 1 commit
  5. 07 Jul, 2026 1 commit
  7. 06 Jul, 2026 1 commit
  9. 04 Jul, 2026 6 commits
  11. 03 Jul, 2026 9 commits
  13. 01 Jul, 2026 1 commit
    • Mahmoud Aglan's avatar
      feat(waiver): live target debt check on create page + require waiver doc · 99e7632a
      Mahmoud Aglan authored 
      - Added GET /api/members/{id}/debts endpoint returning comprehensive
  debt check as JSON (clear, debts array, total)
- Create page now fetches and displays target member debts live after
  selection via AJAX — shows detailed debt table or green "clear" badge
- Form submission blocked if target has outstanding debts, with error
  message and direct link to payment page
- Made waiver request document upload required (HTML validation)
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      99e7632a
  15. 28 Jun, 2026 1 commit
    • Mahmoud Aglan's avatar
      feat(waiver): auto-complete waiver after fee payment instead of manual approval · d92f1d38
      Mahmoud Aglan authored 
      After the cashier collects the waiver fee, the system now automatically
executes the waiver completion (membership transfer) without requiring
a manual "إتمام التنازل" button click.

The auto-complete validates all conditions first:
- Fee paid (status = fee_paid)
- Target member specified
- Board approval exists
- No debts on source or target member
- Excess dependent fees properly set

If any condition fails, the waiver stays in fee_paid status with a
clear checklist showing what's still needed, plus a manual fallback
button for edge cases.
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      d92f1d38
  17. 26 Jun, 2026 4 commits
    • Mahmoud Aglan's avatar
      fix(waiver): handle empty date_of_birth strings in individual fee insert · 26838f17
      Mahmoud Aglan authored 
      MySQL rejects empty strings for DATE columns. The approve form sends
empty strings for persons without a DOB (spouses, temporary members).
Convert empty strings to null for date_of_birth, relationship, status,
and notes fields before INSERT.
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      26838f17
    • Mahmoud Aglan's avatar
      fix(payments): actually update subscription/fine/installment records when paid from process page · 9044313e
      Mahmoud Aglan authored 
      The generic payment process page (linked from waiver "الانتقال إلى السداد") was
recording payments in the payments table but never updating the source records
(subscriptions.paid_amount, fines.paid_amount, installment_schedule.paid_amount).
This caused the debt check to keep showing debts as unpaid after payment.

Added handleSubscriptionPayment, handleFinePayment, and handleInstallmentPayment
methods that mark the underlying records as paid (oldest first).

Also fixed waiver debt check using wrong fines status ('pending' instead of
'imposed'/'appeal_upheld') which is what fines actually use.
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      9044313e
    • Mahmoud Aglan's avatar
      feat(waiver): per-individual fee assignment + fix 404 payment button · c8fae48c
      Mahmoud Aglan authored 
      - New table `waiver_individual_fees` stores fee per person (not per category)
- Board approval screen shows each excess person as a separate card with:
  name, DOB, age, age category, relationship, independent fee type/rate
- Children 25+ flagged with warning and "فصل العضوية" button
- Live JS calculates per-person amounts and updates grand total instantly
- Fee breakdown section shows individual names when individual fees exist
- Fix: /members/{id}/financial → /payments/process/{id} (was 404)
- WaiverProcessor::getExcessIndividuals() identifies the specific excess persons
- WaiverProcessor::saveIndividualFees() persists per-person board decisions
- Age categories expanded: under_12, 12_to_16, 16_to_18, 18_to_25, 25_plus
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      c8fae48c
    • Mahmoud Aglan's avatar
      feat(waiver): Round 2 UX — comprehensive debt check, children details, payment in target's name · 83f24d7a
      Mahmoud Aglan authored 
      - checkDebtsComprehensive() returns per-person breakdown (name, type, debt_type, period, amount)
- getDependentDetails() calculates age, DOB, age category for children
- New sendToCashier route creates payment request in TARGET member's name (buyer pays)
- Detailed receipt breakdown with both member names and per-category fees
- show.php: per-person debt table, children comparison, status indicators, go-to-payment button
- create.php: detailed debt display with person labels, children age table
- Status flow: requested → approved → send to cashier → fee_paid → complete
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      83f24d7a
  19. 23 Jun, 2026 1 commit
  21. 22 Jun, 2026 5 commits
  23. 21 Jun, 2026 3 commits
  25. 19 Jun, 2026 1 commit
    • Mahmoud Aglan's avatar
      Fix waiver duplicate key error + wrong fee calculation + member search name mismatch · 6c3db858
      Mahmoud Aglan authored 
      TKT-71: Fixed duplicate entry for membership_number by reversing operation
order in WaiverProcessor — source member's number is now NULLed BEFORE
assigning it to target member, preventing unique constraint violation.

TKT-71: Waiver fee now calculated from current pricing_configs value instead
of the member's stored membership_value (old/historical price).

TKT-69: Member search duplicate check now shows the entity type (spouse/child)
and the parent member's number, clarifying which person is being shown.
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      6c3db858
  27. 17 Jun, 2026 2 commits
    • Mahmoud Aglan's avatar
      Remove child fees from divorce transfer — fees only on new additions post-separation · 42f0ccc6
      Mahmoud Aglan authored 
      Per bylaws clarification: children transferred during divorce separation move
without fees. Age-based fees (15%/20%/25%/30%) apply only when the new
independent member adds NEW children after the separation is complete.

- Removed child fee calculation from boardApprove flow
- Children selection is now transfer-only (no fee columns)
- Updated fee preview JS to exclude child fees
- Fee breakdown shows "transferred without fees" for moved children
- Total = percentage_fee + form_fee (570) + annual_subscription only
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      42f0ccc6
    • Mahmoud Aglan's avatar
      Use current membership value from pricing_configs for divorce fee calculation · 94e1f426
      Mahmoud Aglan authored 
      Instead of using the stored member.membership_value (which may be outdated),
the divorce module now fetches the current active price from pricing_configs
based on the member's branch and qualification at the time of the request.

- Added DivorceFeeCalculator::getCurrentMembershipValue() method
- Updated boardApprove, show, and create to use current pricing
- Views now display "قيمة العضوية الحالية" with source indicator
- Payment breakdown shows which source was used for the calculation
Co-Authored-By: 's avatarClaude Opus 4.6 <noreply@anthropic.com>
      94e1f426