faster and cheeper mcq generation

self_hosted_env/voice_agent/services/mcq_service.py

@@ -98,12 +98,16 @@ class MCQService:
             # Slice to exact number requested (in case we generated extras)
             final_set = accepted_mcqs[:num_questions]
             self.pgvector.insert_mcqs(final_set)
+            for q in final_set:
+                q.pop('embedding', None)
             return final_set
         
         # If we failed to generate enough
         if not accepted_mcqs:
             logger.warning(f"Could not generate unique questions for {concept} after {attempts} attempts.")
             return []
+        
+        
             
         return accepted_mcqs
 

self_hosted_env/voice_agent/services/pgvector_service.py

@@ -546,31 +546,35 @@ class PGVectorService:
 
 
     def get_mcqs(self, curriculum: str, grade: str, subject: str, unit: str, concept: str, is_arabic: bool, limit: Optional[int] = 10) -> List[Dict]:
-        """
-        Retrieves MCQs for a specific topic and language, now filtering by curriculum.
-        If limit is None, it retrieves all matching questions.
-        """
-        with self.pool_handler.get_connection() as conn:
-            with conn.cursor(cursor_factory=RealDictCursor) as cur:
-                
-                # --- UPDATED SELECT AND WHERE CLAUSE ---
-                query = """
-                    SELECT *
-                    FROM mcq_questions
-                    WHERE curriculum = %s AND grade = %s AND subject = %s AND unit = %s AND concept = %s AND is_arabic = %s
-                    ORDER BY created_at DESC
-                """
-                
-                params = (curriculum, grade, subject, unit, concept, is_arabic)
-                
-                if limit is not None:
-                    query += " LIMIT %s;"
-                    params += (limit,)
-                else:
-                    query += ";"
+            """
+            Retrieves MCQs for a specific topic and language.
+            Removes the 'embedding' field to prevent JSON serialization errors with ndarrays.
+            """
+            with self.pool_handler.get_connection() as conn:
+                with conn.cursor(cursor_factory=RealDictCursor) as cur:
+                    
+                    query = """
+                        SELECT *
+                        FROM mcq_questions
+                        WHERE curriculum = %s AND grade = %s AND subject = %s AND unit = %s AND concept = %s AND is_arabic = %s
+                        ORDER BY created_at DESC
+                    """
+                    
+                    params = (curriculum, grade, subject, unit, concept, is_arabic)
+                    
+                    if limit is not None:
+                        query += " LIMIT %s;"
+                        params += (limit,)
+                    else:
+                        query += ";"
 
-                cur.execute(query, params)
-                return cur.fetchall()
+                    cur.execute(query, params)
+                    results = cur.fetchall()
+                    
+                    for row in results:
+                        row.pop('embedding', None)
+                    
+                    return results
             
 
     def get_distinct_curricula_from_structure(self) -> List[str]: